[flang-commits] [PATCH] D83488: [flang] Change the default F18_FC to gfortran

[Valentin Clement via Phabricator via flang-commits]

clementval added a comment.

In D83488#2142974 <https://reviews.llvm.org/D83488#2142974>, @AlexisPerry wrote:

> I'll admit, this is my first time trying to commit to LLVM directly and using Phabricator (rather than on a fork that uses pull requests), and I'm definitely still learning the workflow.  I had some git issues when first creating the patch that meant my first commit was lost locally, so when I went to update the patch it only had the second commit which caused the original changes to disappear.  I then created a new branch and re-did the changes and updated again, using only a single commit, so that the diff would now have everything in it.
>
> If this has resulted in an unreviewable state for this diff, then I will close it and submit a new one which will hopefully go more smoothly now that I've learned a few things.  Sorry for the confusion.


The diff looks fine now! If you don't use it already, I would recommend to use arcanist to deal with the diff and phabricator ... it makes things easier


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83488/new/

https://reviews.llvm.org/D83488