[flang-commits] [PATCH] D83397: [flang] Replace uses of _Complex with std::complex

Wed Jul 8 08:12:56 PDT 2020

echristo added a comment.

In D83397#2139187 <https://reviews.llvm.org/D83397#2139187>, @schweitz wrote:

> In D83397#2139131 <https://reviews.llvm.org/D83397#2139131>, @echristo wrote:
>
> > In D83397#2139111 <https://reviews.llvm.org/D83397#2139111>, @schweitz wrote:
> >
> > > Hi Eric,
> > >
> > > There is an active development branch for the flang middle end. https://github.com/flang-compiler/f18-llvm-project/tree/fir-dev
> >
> >
> > That's not part of the llvm project.
> >
> > > That code base is being upstreamed piecemeal. Not all of the code is upstreamed at this point. It is simply a false impression that code in the middle of being upstreamed is "unused" or "unnecessary". Since it not all of it is upstreamed, changing interfaces and support code in llvm-project directly is going to cause problems that can become hard to track and resolve while the upstreaming is ongoing.
> >
> > It very much is unused and unnecessary as there are no pieces of that code in the repository.
>
>
> We are stuck between a rock and a hard place. Flang needs a middle end, as it currently can't generate code. Work on that middle end is being done. We are following the rules and trying to upstream that code in small "reviewable" chunks as quickly as possible. It's just simply going to be the case because of the interdependencies involved and the small chunks process that some code will merely appear to be temporally unused.
>
> If you have a better solution to how to change the upstream process, then our group would be happy to hear it.

You commit something as you get a use for it. Partial files etc. At least this is what the rest of us have done. :)

You also still haven't replied with "what bot/compiler/etc is going to break by making this change". Would you please do that?

Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83397/new/

https://reviews.llvm.org/D83397