[flang-commits] [PATCH] D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0
Kiran Kumar T P via Phabricator via flang-commits
flang-commits at lists.llvm.org
Mon Jul 6 21:15:29 PDT 2020
kiranktp added a comment.
In D82931#2132486 <https://reviews.llvm.org/D82931#2132486>, @DavidTruby wrote:
> Looks good to me! As a nit, perhaps you could add some tests that shouldn't parse correctly as well?
Thanks for reviewing the code David!.
> As a nit, perhaps you could add some tests that shouldn't parse correctly as well?
Any syntax error will lead to chain of errors. It will be tough to add a case for invalid syntax.
I will check this once.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82931/new/
https://reviews.llvm.org/D82931
More information about the flang-commits
mailing list