[flang-commits] [PATCH] D83142: [flang] Make 'num_images()' intrinsic

[Peter Klausler via Phabricator via flang-commits]

klausler accepted this revision.
klausler added a comment.
This revision is now accepted and ready to land.

LGTM, and thanks for the contribution.



================
Comment at: flang/lib/Evaluate/intrinsics.cpp:584
     // NULL() is a special case handled in Probe() below
+    {"num_images", {}, DefaultInt, Rank::scalar,
+        IntrinsicClass::transformationalFunction},
----------------
klausler wrote:
> num_images is not an intrinsic procedure in subclause 16 of the standard; `INTRINSIC NUM_IMAGES` would not be a valid statement.  It shouldn't be here with the actual intrinsics unless you're proposing to make it one as an extension.
Whoops, my mistake; I had it confused with another procedure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83142/new/

https://reviews.llvm.org/D83142