[flang-commits] [PATCH] D93105: [Flang][openmp][5.0] Add task_reduction clause.
Valentin Clement via Phabricator via flang-commits
flang-commits at lists.llvm.org
Thu Dec 17 11:41:11 PST 2020
clementval added inline comments.
================
Comment at: flang/lib/Parser/openmp-parsers.cpp:223
+ construct<OmpClause>(construct<OmpClause::TaskReduction>(
+ parenthesized(Parser<OmpReductionClause>{}))) ||
"RELAXED" >> construct<OmpClause>(construct<OmpClause::Relaxed>()) ||
----------------
@sameeranjoshi After our slack discussion, I hope you don't mind but I updated your patch with a working version without the indirection.
The reduction clause is actually not done "right" at the moment since it doesn't follow other clauses. It should be done in a similar way as `TASK_REDUCTION` now. I guess we can do this in a separated patch.
================
Comment at: flang/lib/Parser/unparse.cpp:2007
void Unparse(const OmpReductionClause &x) {
Word("REDUCTION(");
Walk(std::get<OmpReductionOperator>(x.t));
----------------
This will be changed in a follow up patch to reflect the change in `TaskReduction` and `Reduction`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93105/new/
https://reviews.llvm.org/D93105
More information about the flang-commits
mailing list