[flang-commits] [PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

[Valentin Clement via Phabricator via flang-commits]

clementval added inline comments.


================
Comment at: flang/lib/Lower/OpenMP.cpp:242
+  } else if (blockDirective.v == llvm::omp::OMPD_taskgroup) {
+    TODO("");
   }
----------------
sameeranjoshi wrote:
> clementval wrote:
> > If you add the todo can you maybe explicitly add an error message in it?
> What in case we remove it, that's ok is it?
Fine as well. In the current state it doesn't add more. 


================
Comment at: flang/test/Semantics/omp-taskgroup01.f90:36
+
+!  !$omp parallel
+!    !$omp taskgroup task_reduction(+, reduction_var)
----------------
sameeranjoshi wrote:
> clementval wrote:
> > Why is this block commented out? 
> Depends on D93105
Yeah but since you have it as a dependency in phab you can uncomment the block. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93373/new/

https://reviews.llvm.org/D93373