[flang-commits] [PATCH] D93105: [Flang][openmp][5.0] Add task_reduction clause.

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi added a comment.

Thank you for reviewing.



================
Comment at: flang/include/flang/Parser/parse-tree.h:3430
+  TUPLE_CLASS_BOILERPLATE(OmpTaskReductionClause);
+  std::tuple<OmpReductionOperator, OmpObjectList> t;
+};
----------------
clementval wrote:
> sameeranjoshi wrote:
> > clementval wrote:
> > > Is there a good reason why `OmpReductionClause` takes a list of `Designator` and here you take an `OmpObjectList`? 
> > I did ask once the same in slack channel.
> > But I think the complicated checks can be done in semantic part given the tablegen framework.
> > https://flang-compiler.slack.com/archives/CGB8G85QV/p1603382608040500
> I think they should be the same and possibly use the same node for that. 
`OmpReductionClause` now uses `OmpObjectList`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93105/new/

https://reviews.llvm.org/D93105