[flang-commits] [PATCH] D92638: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308)

[Kiran Kumar T P via Phabricator via flang-commits]

kiranktp added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:883
+// Loop iteration variables are not well defined for DD WHILE loop
+// in OpenMP-5.0 standard
+// Use of DO CONCURRENT inside OpenMP construct is unspecified behavior
----------------
clementval wrote:
> kiranchandramohan wrote:
> > clementval wrote:
> > > First line reference 4.5 and here 5.0 .... I think it would be nice to have a homogeneity here. 
> > I think specific point might not be from the OpenMP standard. It is probably a general comment that do while loops might not have iteration variables.
> > 
> > But the ones below are forward looking comments.
> Ok. Just very confusing to have 3 versions of the standard on the same comment blocks. 
As Valentine mentioned, having different standards mentioned under one construct will be very confusing. It would be good to remove references to 5.0 and 5.1 here. As and when we start migrating the next OpenMP version, we can modify these appropriately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92638/new/

https://reviews.llvm.org/D92638