[flang-commits] [PATCH] D78136: [flang][docs]Doxygen support in flang

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi added a comment.

In D78136#1996733 <https://reviews.llvm.org/D78136#1996733>, @DavidTruby wrote:

> In D78136#1992514 <https://reviews.llvm.org/D78136#1992514>, @sameeranjoshi wrote:
>
> > In D78136#1992084 <https://reviews.llvm.org/D78136#1992084>, @DavidTruby wrote:
> >
> > > In D78136#1987218 <https://reviews.llvm.org/D78136#1987218>, @sameeranjoshi wrote:
> > >
> > > > Above doxygen patch seems to fail for me for below flags
> > > >
> > > > cmake ../llvm
> > > >  -DLLVM_ENABLE_DOXYGEN=ON \
> > > >  -DLLVM_BUILD_DOCS=OFF \
> > > >  -DFLANG_INCLUDE_DOCS=OFF \
> > > >
> > > > ninja install
> > >
> > >
> > > I'm not really sure if this combination of flags makes sense anyway, what's the expected behaviour when using these flags? I can't really tell intuitively
> >
> >
> > Expected behavior should not build nor install any documentation and documentation targets(doxygen-flang) should not be visible.
>
>
> Are you sure? I would have thought LLVM_ENABLE_DOXYGEN does expose the doxygen-flang target. But again I don't really have much of an idea.


The CMakeLists.txt file has

  if (FLANG_INCLUDE_DOCS)
    add_subdirectory(docs)
  endif()

When

  FLANG_INCLUDE_DOCS=OFF

IIUC the working of CMake I think the docs/ sub directory won't be added hence no docs/CMakeLists.txt would be present.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78136/new/

https://reviews.llvm.org/D78136