[clangd-dev] [Release-testers] [10.0.0 Release] Release Candidate 1 is here

[Hans Wennborg via clangd-dev]

On Wed, Feb 5, 2020 at 9:00 PM Anil Mahmud <anil.mahmud.llvm at gmail.com> wrote:
>
> Hello,
>
> When running test-release.sh using GCC 5.4.0 we encountered this error :
>
> /home/anil/llvm1000_rc1_binary_upload/rc1/llvm-project/clang-tools-extra/clangd/Hover.cpp: In function ‘llvm::StringLiteral clang::clangd::{anonymous}::getNameForExpr(const clang::Expr*)’:
> /home/anil/llvm1000_rc1_binary_upload/rc1/llvm-project/clang-tools-extra/clangd/Hover.cpp:450:10: error: could not convert ‘(const char*)"expression"’ from ‘const char*’ to ‘llvm::StringLiteral’
>    return "expression";
>           ^
>
> This was fixed by the  commit  40514a7d
[..]
> Can this be backported to RC1 10.0.0 ?

Yes, thanks for finding it! Cherry-picked to the 10.x branch as
cbec01fe05895abe96f2cb80e24367dec60209ee (We can't backport it to RC1
since that's already been released, but this will be part of RC2.)

Thanks,
Hans