[clangd-dev] [Release-testers] [8.0.0 Release] rc1 has been tagged

[Michał Górny via clangd-dev]

On Thu, 2019-01-24 at 19:58 +0100, Dimitry Andric via Release-testers
wrote:
> On 24 Jan 2019, at 01:49, Hans Wennborg via Release-testers <release-testers at lists.llvm.org> wrote:
> > 
> > 8.0.0-rc1 was just tagged (from the branch at r351980).
> > 
> > It took a little longer than planned, but it's looking good.
> > 
> > Please run the test script, share your results, and upload binaries.
> 
> Unfortunately I'm running into a problem with check-all, where it fails to link XRayTest-x86_64-Test:
> 
> [100%] Generating XRayTest-x86_64-Test
> /home/dim/llvm/8.0.0/rc1/Phase3/Release/llvmCore-8.0.0-rc1.obj/./lib/libLLVMSupport.a(Signals.cpp.o): In function `llvm::sys::PrintStackTrace(llvm::raw_ostream&)':
> Signals.cpp:(.text._ZN4llvm3sys15PrintStackTraceERNS_11raw_ostreamE+0x24): undefined reference to `backtrace'
> Signals.cpp:(.text._ZN4llvm3sys15PrintStackTraceERNS_11raw_ostreamE+0x254): undefined reference to `llvm::itaniumDemangle(char const*, char*, unsigned long*, int*)'
> clang-8: error: linker command failed with exit code 1 (use -v to see invocation)
> gmake[3]: *** [projects/compiler-rt/lib/xray/tests/unit/CMakeFiles/TXRayTest-x86_64-Test.dir/build.make:73: projects/compiler-rt/lib/xray/tests/unit/XRayTest-x86_64-Test] Error 1
> gmake[3]: Target 'projects/compiler-rt/lib/xray/tests/unit/CMakeFiles/TXRayTest-x86_64-Test.dir/build' not remade because of errors.
> gmake[2]: *** [CMakeFiles/Makefile2:33513: projects/compiler-rt/lib/xray/tests/unit/CMakeFiles/TXRayTest-x86_64-Test.dir/all] Error 2
> gmake[2]: Target 'CMakeFiles/check-all.dir/all' not remade because of errors.
> gmake[1]: *** [CMakeFiles/Makefile2:737: CMakeFiles/check-all.dir/rule] Error 2
> gmake[1]: Target 'check-all' not remade because of errors.
> gmake: *** [Makefile:277: check-all] Error 2
> [Release Phase3] check-all failed
> 
> It appears this is because -lexecinfo is not passed to the link command line, but I'm unsure why this only seems to affect the XRay test.  I'm investigating, but if anybody has a cluestick, please hit me. :-)
> 

We've been having similar issue on NetBSD in the past.  Long story
short, the code around there is not using CMake rules to build stuff but
a custom compiler invocation, and therefore it does not inherit library
dependencies from CMake.

Short-term solution is to figure out what's missing and add it, with
appropriate conditionals.

Long-term solution (which is probably not suitable for 8.0.0) is to
rewrite that whole stuff.  Probably could work by creating a custom
language for CMake that's like C but uses just-built clang, etc. 
However, that's just my theory and I'm not 100% sure it'll work or how
much work it'd involve.

-- 
Best regards,
Michał Górny
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/clangd-dev/attachments/20190124/aae00497/attachment.sig>