[cfe-dev] Identifier naming inconsistencies in clang

[Craig Topper via cfe-dev]

The coding guidelines here
https://llvm.org/docs/CodingStandards.html#introduction say

"There are some conventions that are not uniformly followed in the code
base (e.g. the naming convention). This is because they are relatively new,
and a lot of code was written before they were put in place. Our long term
goal is for the entire codebase to follow the convention, but we explicitly *do
not* want patches that do large-scale reformatting of existing code. On the
other hand, it is reasonable to rename the methods of a class if you’re
about to change it in some other way. Please commit such changes separately
to make code review easier."

But it has said that for a long time so I don't know what the feeling is
these days.

~Craig


On Tue, Jan 11, 2022 at 3:17 PM Richard via cfe-dev <cfe-dev at lists.llvm.org>
wrote:

> Hi Team,
>
> So... my IDE has settings to recognize identifier naming conventions
> and it's constantly flagging various bits of clang code as not
> following the convention, typically:
>
> - Methods/functions that don't begin with lower-case letter
> - Variables that don't begin with upper-case character
> - Occasionally methods/variables using underscores as word separators
>
> Is it acceptable to submit NFC refactoring changes that address the
> inconsistencies or does it require a phabricator review?
>
> Thanks,
>
> -- Richard
>
> --
> "The Direct3D Graphics Pipeline" free book <
> http://tinyurl.com/d3d-pipeline>
>              The Terminals Wiki <http://terminals-wiki.org>
>      The Computer Graphics Museum <http://ComputerGraphicsMuseum.org>
>   Legalize Adulthood! (my blog) <http://LegalizeAdulthood.wordpress.com>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20220111/68b40877/attachment.html>