[cfe-dev] [clang-tidy][Sema][AST] Different behavior Sema and AST matcher

[Carlos Galvez via cfe-dev]

Hi!

As proposed by @whisperity I'm posting here to ask about a strange
situation we found in the following bug fix:

https://reviews.llvm.org/D110614

We had a matcher to detect if a class has a public virtual destructor:

has(cxxDestructorDecl(isPublic(), isVirtual())),

However this didn't work for class templates, see details:

https://reviews.llvm.org/D110614#3032760

The workaround was to create a custom matcher that seems to do the same
thing as the original matcher, but it actually works for templates because
it calls cxxDestructorDecl::isVirtual() (from Sema), which correctly
propagates the virtual specifier from the base class.

Is this a concern, and should someone look into Sema/AST? (I'm
unfortunately a n00b here). Or should we just merge the clang-tidy fix and
move on?

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20211010/3848cd2f/attachment.html>