[cfe-dev] RFC: Update LLVM_VERSION_SUFFIX CMake variable for release candidates

[Tom Stellard via cfe-dev]

On 7/1/21 8:26 AM, Ben Boeckel wrote:
> On Tue, Jun 29, 2021 at 10:39:01 -0700, Tom Stellard via cfe-dev wrote:
>> I would like to propose that we start using the LLVM_VERSION_SUFFIX
>> CMake variable for release candidates.  For example:
>> after the release/13.x branch is created, instead of changing
>> LLVM_VERSION_SUFFIX from "git" to "", we would change it to "rc1",
>> then after the 13.0.0-rc1 release is tagged, we would update the
>> variable to "rc2", etc. Then right before the final release has been
>> tagged, we would set it to ""
> 
> Just a note that this can be confusing because there would now have
> builds reporting as `13.0.0-rc1` without any corresponding tag in the
> repository. I think that instead of doing that, changing it to be
> `13.90.0` or something to indicate "after 13, but not yet 14" while
> avoiding any (plausible) `13.x` release number might be a better
> strategy.
> 

This is the situation now, because the version of llvm in the release/13.x
branch is 13.0.0 before there is a 13.0.0 tag.

We use the minor release number for ABI breaking releases sometimes, so I
don't think we can use it to indicate 'almost' the next version.

-Tom

> I learned this trick from KDE by the way if any prior art is wanted.
> 
> (Just an outside observer, FWIW.)
> 
> --Ben
>