[cfe-dev] [RFC] Clang SourceLocation overflow

Mikhail Maltsev via cfe-dev cfe-dev at lists.llvm.org
Mon Feb 22 09:30:46 PST 2021


On 03/02/2021 19:54, Richard Smith via cfe-dev wrote:
>     My preference is obviously to just make SourceLocation be uint64_t
>     instead, but the impact on AST size is going to be significant.  So
>     I guess I’m hoping that Richard Smith can comment and help us figure
>     out how much pain we are willing to go through for this?
> 
> 
> We could do that, and having a build-time selector for 32/64-bit 
> SourceLocations seems like it might not impose a huge cost. 

I've posted an RFC patch which implements this approach, including some 
benchmark results: https://reviews.llvm.org/D97204

Could you please have a look?

-- 
Regards,
   Mikhail Maltsev


More information about the cfe-dev mailing list