[cfe-dev] Clang doesn't warn about wrong sized mallocs

[Joerg Sonnenberger via cfe-dev]

On Mon, Aug 16, 2021 at 03:48:54PM +0000, Keane, Erich via cfe-dev wrote:
> I think the only valid thing to check here is allocated 'smaller', since:
> 
> struct S *s = malloc(sizeof(struct S) * 10); // An array
> struct S *s2 = malloc(sizeof(struct S) + 5); // a struct with some level of trailing storage, shows that multiple-of isn't sufficient
> 
> are both valid/reasonably common uses of malloc.

It depends. The former is certainly valid and common, but the latter
should only be valid if the last member is a (flexible) array. There are
certainly levels of quality here.

Does clang-tidy or clang-analyze complain about multiplicative arguments
in general? E.g. malloc(sizeof(S) * len) ?

Joerg