[cfe-dev] [RFC] Changing tool search path priority

[David Spickett via cfe-dev]

Given the lack of response (they may be using different addresses with the
changes to MIPS since that time) I intend to get the current patch reviewed
as is. Keeping the default triple behaviour the same. Then do a follow up
change to remove the default triple behaviour, which can be reverted more
easily if needed.

On Fri, 15 May 2020 at 06:58, Fangrui Song via cfe-dev <
cfe-dev at lists.llvm.org> wrote:

> On 2020-05-14, Joerg Sonnenberger via cfe-dev wrote:
> >On Thu, May 14, 2020 at 03:11:23PM +0100, David Spickett wrote:
> >> > ...but I don't think we should ever be looking for
> >> > ${DEFAULT_TRIPLE}-gcc. That doesn't make sense to me at all.
> >>
> >> IIt was added in https://reviews.llvm.org/D13340. Quoting a comment
> there:
> >> ""LLVMDefaultTargetTriple is the value specified with the CMake
> >> variable -DLLVM_DEFAULT_TARGET_TRIPLE= during configuration time. For
> >> example, using --target=mips64el-mti-linux will search for files
> prefixed
> >> with either mips64el-mti-linux-{as,ld} and mips-mti-linux-{as,ld} in our
> >> toolchain where we specify -DLLVM_DEFAULT_TARGET_TRIPLE=mips-mti-linux."
> >>
> >> I guess that allows you to only package one copy of tools that can
> handle
> >> both targets.
> >
> >That seems ..strangely specific. We certainly have cases where multiple
> >architecture variants are targetting a single binutils environment in
> >NetBSD, but those are all controlled by the appropiate flags to the
> >tools. The default target doesn't leak through and I don't think it ever
> >should. That completely defeats the goal of a universal toolchain.
> >
> >Joerg
>
> I vote for not checking ${LLVM_DEFAULT_TARGET_TRIPLE}-gcc if --target is
> specified.
>
> CCed people from https://reviews.llvm.org/D13340
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20200528/f8557698/attachment.html>