[cfe-dev] [clangd-dev] PCH/preamble files that exceeds 512M

[Dmitry Polukhin via cfe-dev]

I found 2 more cases when 32-bit offsets are not enough: DeclOffests and
TypeOffssts. They belong to DECLTYPES_BLOCK block that usually takes about
2/3 of the file and on 900M preamble file exceeds 512M alone. In such cases
I'm using 64-bit offsets.
Diff https://reviews.llvm.org/D76594 was updated to handle these cases. If
you are interested in large AST files support, please review.

On Mon, Mar 23, 2020 at 9:09 AM Dmitry Polukhin <dmitry.polukhin at gmail.com>
wrote:

> https://reviews.llvm.org/D76594 implements relative offsets for 32-bit
> bit offsets. I tried to find all potentially problematic places and found
> one more that I didn't identify initially PPD_ENTITIES_OFFSETS.
>
> On Wed, Mar 18, 2020 at 5:42 PM Dmitry Polukhin <dmitry.polukhin at gmail.com>
> wrote:
>
>> OK, it seems that there is kind of consensus that second option is better
>> and additional complexity worths it. My main concern about second option is
>> that it is kind of temporary solution that just delays the point then 32bit
>> won't be enough for bit offsets.
>> I'll explore second option in more details and post results here.
>>
>> On Wed, Mar 18, 2020 at 1:13 AM Bruno Cardoso Lopes <
>> bruno.cardoso at gmail.com> wrote:
>>
>>>
>>>
>>> On Tue, Mar 17, 2020 at 12:57 PM Duncan P. N. Exon Smith <
>>> dexonsmith at apple.com> wrote:
>>> >
>>> > +Michael, Bruno, and Volodymyr
>>> >
>>> > I agree with Sam that option 2 seems cleaner.
>>>
>>> +1
>>>
>>> > I'm not sure whether 4% (option 1) would be a blocker for us, but
>>> probably it would be fine.
>>>
>>> Ultimately I believe it would be fine.
>>>
>>> --
>>> Bruno Cardoso Lopes
>>> http://www.brunocardoso.cc
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20200328/170c672d/attachment-0001.html>