[cfe-dev] Turn off lint pre-merge checks for test/
Bruno Ricci via cfe-dev
cfe-dev at lists.llvm.org
Mon Jul 6 06:31:50 PDT 2020
On 06/07/2020 14:04, Nathan James via cfe-dev wrote:
> Some of the test folders already have .clang-format files which just
> override the column limit
> ----------------------------------------------------
> BasedOnStyle: LLVM
> ColumnLimit: 0
> ----------------------------------------------------
> If the issues with formatting are just FileCheck comments being too
> long, this is a probably the way to go.
> If the issue with formatting is say trying to extract some kind of
> diagnostic it may be wise to just wrap the bad code in `clang-format
> on/off` comments.
> Losing all formatting of test files would be a step backwards WDYT?
>
> ~Nathan
>
Hum, so there is already test/.clang-format which does the above.
In the patch which motivated this email (https://reviews.llvm.org/D83183)
most of the noise is caused by complaints about the indentation of CHECK lines.
Perhaps I just need to do a quick clang-format and forget about it.
Bruno
More information about the cfe-dev
mailing list