[cfe-dev] Turn off lint pre-merge checks for test/

Bruno Ricci via cfe-dev cfe-dev at lists.llvm.org
Mon Jul 6 06:08:24 PDT 2020



On 06/07/2020 13:55, MyDeveloper Day wrote:
> Maybe it is time to add capability for a .clang-format-ignore file that can work across the tree, then those that want to turn them off could? 
> 
> There are some areas where the tests are already clean. It would be a shame to not keep them so, but I understand that FileCheck sometimes might need comments with length that don't meet the style guide
> 
> For now could you simply add a local .clang_format file in the test directory to turn clang-format off

I'm not sure I follow.. .What do you mean by "local"? Local to my tree or local to the test/ folder?
I was talking about the warnings which comes up in the Phab interface.

Bruno

> 
> e.g.
> --------------------------------------------------
> BasedOnStyle:LLVM
> DisableFormat: true
> --------------------------------------------------  
> 
> MyDeveloperDay
> 
> On Mon, Jul 6, 2020 at 1:47 PM Aaron Ballman via cfe-dev <cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>> wrote:
> 
>     On Mon, Jul 6, 2020 at 8:39 AM Bruno Ricci via cfe-dev
>     <cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>> wrote:
>     >
>     > Would it be possible to turn off the lint pre-merge checks for
>     > the test/ folder? The suggestion to run clang-format on the tests
>     > is not useful and adds a lot of noise to the diff.
> 
>     Strong +1. Same for running clang-tidy checks, etc.
> 
>     ~Aaron
> 
>     >
>     > Bruno Ricci
>     > _______________________________________________
>     > cfe-dev mailing list
>     > cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>
>     > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>     _______________________________________________
>     cfe-dev mailing list
>     cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>
>     https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
> 


More information about the cfe-dev mailing list