[cfe-dev] RFC: Easier AST Matching by Default

[Aaron Ballman via cfe-dev]

On Tue, Jun 30, 2020 at 3:47 PM Stephen Kelly via cfe-dev
<cfe-dev at lists.llvm.org> wrote:
>
>
> On 30/06/2020 00:22, David Rector wrote:
>
> Bottom line: you’ve raised a great but subtle point, doggedly pursued it, but now, let’s just get rid of the half measures — let’s go all out with a solution that is easy and lifts all boats.
>
>
> I don't agree that it's a half-measure if we don't go with your proposal. I deliberately didn't pursue your proposal long ago.
>
> I don't think you pointed out anything in your proposal regarding the clang-query feature.
>
> I agree that typeloc matching can also be improved. I've focussed on Exprs so far.
>
> I think it would be great to conclude this thread with either
>
> 1) at least a reversal of the default (perhaps so that you can pursue your design) or
>
> 2) intention to proceed in the way things are already going with my design.
>
> I don't mind which we do.
>
> I don't want to be left with the blame of having my design half-implemented though :). There are bugs that I can not fix, partly because this is not concluded.
>
> If I can't move forward, then reversal is the only way (to give others the space to validate their designs) and I'd like to do that soon, so that this thread is not an open item for me (or anyone else) to deal with.

While I was previously in favor of switching the default because I
thought it would lead to easier AST matching, I've been convinced by
the concerns raised on the thread and I think that we should revert
the default to AsIs. Despite that, Stephen: thank you for all your
efforts on this and I'm sorry that the experiment hasn't worked out
the way we had anticipated.

~Aaron