[cfe-dev] update_cc_test_checks.py and function declarations

Alexander Richardson via cfe-dev cfe-dev at lists.llvm.org
Thu Jan 30 06:45:26 PST 2020


Hi David,

This looks like a regression from when I added the JSON AST dump parsing
code.
I never tried using it on a file with both definition and declaration for
the same function. I've posted https://reviews.llvm.org/D73708 which should
fix this issue.

Alex

On Wed, 29 Jan 2020 at 17:56, David Greene <dag at cray.com> wrote:

> David Greene <dag at cray.com> writes:
>
> > void foo();
> >
> > int main() {
> >   foo();
> >   return 0;
> > }
> >
> > void foo() {
> >   ...
> > }
> >
> > The checks for foo were put in front of the definition of foo.  Now I am
> > seeing the checks put in front of the declaration of foo, which messes
> > up the CHECK-LABEL ordering.
>
> Actually, I see the checks place *both* before the declaration *and*
> before the definition.
>
>                       -David
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20200130/17bbbf1f/attachment.html>


More information about the cfe-dev mailing list