[cfe-dev] [RFC] Use preferred alignment instead of ABI alignment for complete object when applicable

Hubert Tong via cfe-dev cfe-dev at lists.llvm.org
Mon Aug 24 12:39:22 PDT 2020

On Mon, Aug 24, 2020 at 12:29 PM James Y Knight <jyknight at google.com> wrote:

> Making a change like that privately while you're working through the list
> of callers could be a useful strategy to help keep track of which callers
> you've checked for correctness already. It might even be useful to send in
> a draft review, to ask for help in determining which of these callsites
> should and should not be modified.
> But I don't think it'd be useful to actually check that change in.
Actually checking it in temporarily can locate additional calls in
patches-in-flight. That is a possible advantage.

> I currently would expect that the vast majority of the time, the code
> is correct to be using the guaranteed "ABI" alignment, and only a small
> number of places need to be changed to use the preferred type alignment.
Are these places sufficiently rare that we are unconcerned with occurrences
of these that may be exclusively downstream at this point in time?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20200824/a3041c3a/attachment.html>

More information about the cfe-dev mailing list