[cfe-dev] Bug 46682 : Check the explicit keyword declaration - Clang crashed in clang/lib/Sema/DeclSpec.cpp:1019 Assertion

Gousemoodhin Nadaf via cfe-dev cfe-dev at lists.llvm.org
Sun Aug 2 14:19:12 PDT 2020


Hello Team,
Reworked on comments, please review  https://reviews.llvm.org/D83929

Regards,
Nadaf

On Wed, Jul 29, 2020 at 5:02 PM Gousemoodhin Nadaf <nadafgouse5 at gmail.com>
wrote:

> Hello Team,
> Reminder!.
> Please review changes  https://reviews.llvm.org/D83929
>
> Regards,
> Nadaf.
>
> On Wed, Jul 22, 2020 at 3:48 PM Gousemoodhin Nadaf <nadafgouse5 at gmail.com>
> wrote:
>
>> Hello Min-Yih,
>> Yes, I added *clang-c* group as reviewers
>>
>> Regards,
>> Nadaf.
>>
>> On Wed, Jul 22, 2020 at 3:39 PM Min-Yih Hsu <minyihh at uci.edu> wrote:
>>
>>> I will recommend to at least assign the code owners of that section as
>>> reviewers. Empty reviewer list will make that ticket never being closed.
>>>
>>> -Min
>>>
>>> On Jul 22, 2020, at 12:18 PM, Gousemoodhin Nadaf via cfe-dev <
>>> cfe-dev at lists.llvm.org> wrote:
>>>
>>> Hello Team,
>>> Please review changes:  https://reviews.llvm.org/D83929
>>>
>>> *Problem:* Compiler crash, compiler does not check explicit declaration
>>> context, whether it is inside class context or not, this check is missing.
>>>
>>> *Solution*: I have added a check when the compiler encounters the
>>> 'explicit' keyword, the first compiler has to check its declaration
>>> context. If the declaration of 'explicit' the keyword is in the class
>>> context, it is correct, else the compiler has to throw warning message (not
>>> crash).
>>>
>>> Regards,
>>> Nadaf.
>>> _______________________________________________
>>> cfe-dev mailing list
>>> cfe-dev at lists.llvm.org
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>>>
>>>
>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20200802/9fd805db/attachment.html>


More information about the cfe-dev mailing list