[cfe-dev] clang-apply-replacements not de-duplicating replacements

[Riyaz Puthiyapurayil via cfe-dev]

Version 7.1.0

-----Original Message-----
From: Malcolm Parsons <malcolm.parsons at gmail.com> 
Sent: Wednesday, March 6, 2019 3:45 AM
To: Riyaz Puthiyapurayil <riyaz.puthiyapurayil at synopsys.com>
Cc: cfe-dev at lists.llvm.org
Subject: Re: [cfe-dev] clang-apply-replacements not de-duplicating replacements

On 05/03/2019 01:43, Riyaz Puthiyapurayil via cfe-dev wrote:
> I have the following YAML file generated from clang-tidy (test-case at 
> the end of the email). Notice that there are two identical 
> replacements /u/riyaz/test.cc at offset:117. I am aware that clang-tidy 
> does NOT de-duplicate replacements. But I thought 
> clang-apply-replacements was supposed to do it. However, it adds the 
> replacement text (override
> keyword) @offset:117 twice.

Which version of clang-apply-replacements are you referring to?

clang-apply-replacements does de-duplicate replacements in all branches except release_70.
See https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_rL342951&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=mMZWMrEZcvPMLSsEQSah9FOTwza1UudSDkAneN47U9lD3qu6gt3kpnIb4MWV77cM&m=pJ8riPQzyGtHsF_hZ_SpNYhBFNoi_cz7_JtkACobu00&s=YGL83wKZLaPO0DlrhhoP3_N5a1lTe6mTNNByF5DF0U4&e=

--
Malcolm Parsons