[cfe-dev] [llvm-dev] FYI: LLVM Phabricactor notifications.

[via cfe-dev]

As there is no mention of the repository being change the revisions feed (https://reviews.llvm.org/D62616) I suspect it was created that way, and its only as the commit fires that it gets added.  (it might be clearer if a herald rule so these are added at review creation, although anyone then removing them will get them readded at commit if they still have the incorrect repository.)

Note the highlighted part of this quote from the revision-closed email:

This revision was automatically updated to reflect the committed changes.
Closed by commit rL362363: [CodeComplete] Add a bit more whitespace to completed patterns (authored by ibiryukov, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The LLVM project was added at the time Phabricator saw the closing commit, not when the revision was created.
If it had been added at the time the revision was created, all review emails would have gone to both lists. They did not.
--paulr

From: MyDeveloper Day [mailto:mydeveloperday at gmail.com]
Sent: Monday, June 03, 2019 11:53 AM
To: Robinson, Paul
Cc: dlj at google.com; llvm-dev; clang developer list; Aaron Ballman
Subject: Re: [llvm-dev] FYI: LLVM Phabricactor notifications.

PaulR

(sorry again if this is known knowledge)

> There's no reason for Herald to be adding project LLVM/subscriber llvm-commits at the last second here.

Its possible the rL (LLVM) had be added as the repository in the review on creation rather than rCFE, if thats the case then the herald rule "H270" is going to fire because it see the repository in the review, so add LLVM project and llvm-commits as a subscriber automatically. It won't care that this has gone into rCFE and not rL  (I mean it does go into rL via the cfe/trunk but I'm not sure if you want to notify for that)

As there is no mention of the repository being change the revisions feed (https://reviews.llvm.org/D62616) I suspect it was created that way, and its only as the commit fires that it gets added.  (it might be clearer if a herald rule so these are added at review creation, although anyone then removing them will get them readded at commit if they still have the incorrect repository.)

MyDeveloperDay (Paul)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20190603/bd55169b/attachment.html>