[cfe-dev] [-Wdocumentation][RFC] \param with multiple identifiers

Mark de Wever via cfe-dev cfe-dev at lists.llvm.org
Sun Aug 25 13:02:44 PDT 2019


On Sun, Aug 25, 2019 at 08:25:31PM +0100, Bruno Ricci wrote:
> 
> > 1.
> > I can change ParamIndex to a SmallVector and change the AST output to
> >   [in] explicitly Param="x,y,z" ParamIndex=1 ParamIndex=2 ParamIndex=3
> > I wonder whether that would make the users of the AST output happy.
> > Suddenly there can be multiple ParamIndex 'fields'.
> 
> Note however that AST classes are allocated with a BumpPtrAllocator, and
> that therefore their destructor is not executed. They should therefore be
> trivially destructible. This is not currently enforced but I have put two
> patches for review (D66646 and D66722) which enforce this with a static_assert.

You're totally right. I should have written ArrayRef. Thanks for your
patches, I already had a look at D66722.

Cheers,
Mark



More information about the cfe-dev mailing list