[cfe-dev] Should functions returning bool return true or false on success?

[Nico Weber via cfe-dev]

Hi,

in https://reviews.llvm.org/D52143 there's some uncertainty if LLVM code
prefers

  if (!Function())
    // Call to function failed, deal with it

or

  if (Function())
    // Call to function failed, deal with it

(Note that this is about functions returning bool, not int.)

Folks on that review feel that returning true on success is probably what
we want, but it's not documented anywhere and we do have both forms in the
codebase.

True on success seems more common:
http://llvm-cs.pcc.me.uk/?q=true+on+success
http://llvm-cs.pcc.me.uk/?q=true+on+error

Does anyone have a pointer to previous on-list discussion on this? If not,
this thread could be the place where we sort this out once and for all :-)

Apologies for the bike-sheddy topic.

Nico
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20180917/b2502481/attachment.html>