[cfe-dev] libc++ is not using always_inline anymore!

[Eric Fiselier via cfe-dev]

Thanks for all the hard work Louis!

I know a lot of our users are going to appreciate this.

/Eric

On Mon, Oct 29, 2018 at 6:44 PM John McCall via cfe-dev <
cfe-dev at lists.llvm.org> wrote:

> > On Oct 29, 2018, at 5:41 PM, Louis Dionne via cfe-dev <
> cfe-dev at lists.llvm.org> wrote:
> >
> > Folks,
> >
> > Today, I pushed a change that disables the use of always_inline for
> visibility purposes in libc++. The change was reviewed as
> https://reviews.llvm.org/D52405. This patch is the culminating point of
> several discussions about libc++'s visibility annotations.
> >
> > This change should have a positive impact on code size for almost any
> application using the libc++ headers. For example, Eric Fiselier reported a
> 7% improvement in size for the Chrome binary after applying this patch. We
> are still in the process of gathering more data like this, but we expect
> similar gains to be possible in other applications. The debugging
> experience should also be much improved as we don't inline every function
> into its caller.
> >
> > However, one word of caution: even though we were very careful not to
> break the ABI or any of libc++'s users ABI, this patch changes things that
> have been in place in libc++ for a long time. It is possible that we
> uncover problems with it, although we hope that won't be the case. If you
> start seeing problems you think are caused by this change, please notify me
> right away so we can take a look.
> >
> > I'll post updates here as we're able to publish more data and
> observations about the results of this patch.
>
> Thanks, Louis!
>
> John.
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20181029/f577ffad/attachment.html>