[cfe-dev] Calling the clang-tools-extra source directory 'extra'

[Shoaib Meenai via cfe-dev]

See http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo

From: cfe-dev <cfe-dev-bounces at lists.llvm.org> on behalf of cfe-dev <cfe-dev at lists.llvm.org>
Reply-To: Franz Fehringer <fehrin2 at googlemail.com>
Date: Thursday, October 4, 2018 at 8:50 AM
To: cfe-dev <cfe-dev at lists.llvm.org>
Subject: Re: [cfe-dev] Calling the clang-tools-extra source directory 'extra'

What is the address / url of the monorepo (git / http / svn ...)?

Am 04.10.2018 um 16:49 schrieb Zachary Turner via cfe-dev:
Are you not using a monorepo?  I think the supported workflow going forward is to use the monorepo, and there is an effort (which seems temporarily stalled, but should still happen) to make this the only supported workflow.  So I'd suggest we focus all documentation efforts on pointing people towards the monorepo.

If you are using the monorepo, then clang-tools-extra would be under a top-level folder called clang-tools-extra, and everything would just work.

On Wed, Oct 3, 2018 at 11:23 AM Stephen Kelly via cfe-dev <cfe-dev at lists.llvm.org<mailto:cfe-dev at lists.llvm.org>> wrote:

Hi,

The buildsystem in clang/tools/CMakeLists.txt currently requires that
clang-tools-extra, if present, is checked out/cloned to a directory
called 'extra'.

This is not made clear in the git instructions, so the first thing I've
always done with a new machine or build is replace that call with a call
to `add_clang_subdirectory`.

I updated the buildsystem and docs with these proposed commits:

  https://reviews.llvm.org/D52819<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D52819&d=DwMDaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=Hpa99Shyj9vdUM0wdVHZPBdEQNGe5-uOaeXsZfbjeAU&s=OlXxUnlMb0wmk9xOSrUhILhK64rblaITopX6tsZXIg8&e=>
  https://reviews.llvm.org/D52820<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D52820&d=DwMDaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=Hpa99Shyj9vdUM0wdVHZPBdEQNGe5-uOaeXsZfbjeAU&s=PJb-0VJxxiQIECq0vB1N2S6bkbZ_N_qdVv_l3iPQf2Q&e=>

Any thoughts?

Thanks,

Stephen.

_______________________________________________
cfe-dev mailing list
cfe-dev at lists.llvm.org<mailto:cfe-dev at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev<https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Ddev&d=DwMDaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=Hpa99Shyj9vdUM0wdVHZPBdEQNGe5-uOaeXsZfbjeAU&s=8oxQNLJ_vfbLI0Hli7RGKIG-e0jGx0aEfy8yC7l3B3A&e=>




_______________________________________________

cfe-dev mailing list

cfe-dev at lists.llvm.org<mailto:cfe-dev at lists.llvm.org>

http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev<https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Ddev&d=DwMDaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=Hpa99Shyj9vdUM0wdVHZPBdEQNGe5-uOaeXsZfbjeAU&s=8oxQNLJ_vfbLI0Hli7RGKIG-e0jGx0aEfy8yC7l3B3A&e=>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20181004/46477098/attachment.html>