[cfe-dev] AST for expresions in array sizes

[Whisperity via cfe-dev]

This is I think because the expression is in truth, not an expression
because part of it comes from the preprocessor. So at parse time,
Clang I think sees "10 + 3" there, not "MACRO + 3". Without going back
to the preprocessor and retrieving the state or tokens from it, you
won't be able to grab this extra information. (Although I'm not sure
how the compiler warning notes do this...)

If you don't use a preprocessor macro but rather a real expression,
the AST contains the expression verbatim:

    |-DeclStmt 0x1b31c38 <line:8:3, col:18>
    | `-VarDecl 0x1b31bd8 <col:3, col:17> col:8 used tmp 'char [x + 3]'
    |-BinaryOperator 0x1b31d10 <line:10:3, col:12> 'char' lvalue '='
    | |-ArraySubscriptExpr 0x1b31cb0 <col:3, col:8> 'char' lvalue
    | | |-ImplicitCastExpr 0x1b31c98 <col:3> 'char *' <ArrayToPointerDecay>
    | | | `-DeclRefExpr 0x1b31c50 <col:3> 'char [x + 3]' lvalue Var
0x1b31bd8 'tmp' 'char [x + 3]'
    | | `-IntegerLiteral 0x1b31c78 <col:7> 'int' 0
    | `-ImplicitCastExpr 0x1b31cf8 <col:12> 'char' <IntegralCast>
    |   `-IntegerLiteral 0x1b31cd8 <col:12> 'int' 1

Or for a more whacky one:

    |-DeclStmt 0x11bdc28 <line:8:3, col:41>
    | `-VarDecl 0x11bdbc8 <col:3, col:40> col:8 used tmp 'char [x * 2
+ 5 - 1 / 2 * x * x + 42]'

This is still not a "BinaryOperator" but perhaps somehow the type
could be fetched out from this and then the inner expression
generated. It could be that only the dumper function is "lazy" about
this.

; Whisperity.
Dávid Bolvanský via cfe-dev <cfe-dev at lists.llvm.org> ezt írta
(időpont: 2018. okt. 1., H, 12:35):
>
> Hello,
>
> #define MAX 10
>
> int main() // (int n)
> {
> char arr[MAX * 3]; // arr[n + 3]
> }
>
> I expected that AST would be more detailed (e.g. Binary Operator) but Clang seems to fold it:
> TranslationUnitDecl
> `-FunctionDecl <line:11:1, line:14:1> line:11:5 main 'int ()'
> `-CompoundStmt <line:12:1, line:14:1>
> `-DeclStmt <line:13:3, col:20>
> `-VarDecl <col:3, col:19> col:8 arr 'char [30]'
>
> or raw output
> `-VarDecl <col:3, col:15> col:8 a 'char [n * 3]'
>
> So with the current AST output we are unable to determine overflowing in array sizes, as requested in https://bugs.llvm.org/show_bug.cgi?id=27439, right?
>
> Is it possible to disable that folding / enhance VarDecl for arrays?
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev