[cfe-dev] build error on Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/clangStaticAnalyzerCore.dir/SarifDiagnostics.cpp.o

[Aaron Ballman via cfe-dev]

On Mon, Nov 5, 2018 at 9:05 PM Artem Dergachev <noqnoqneo at gmail.com> wrote:
>
> Grady: Hmm, buildbots chewed through this just fine, even those on macOS with older compilers, and it does compile for me on a newer compiler as well.
>
> Aaron: I don't know if sys::path::const_iterator is an STL forward iterator; from the doxygen (http://llvm.org/doxygen/classllvm_1_1sys_1_1path_1_1const__iterator.html) it looks like it's only an input iterator, which is not enough (it will be enough when we move to C++17). I guess we can always stuff a simple iterator loop in there and it should compile just fine; do you have any immediate ideas on how to preserve the expressiveness of std::for_each here?

Yeah, I think you're correct, this needs to be a forward iterator
rather than an input iterator. I think this will have to go back to
using a for loop for now. It's not ideal, but it at least fixes the
issue.

~Aaron

>
> On 11/2/18 2:41 PM, Grady Player via cfe-dev wrote:
>
> from master branch
>
> svn log -l 1
> ------------------------------------------------------------------------
> r346029 | aheejin | 2018-11-02 12:38:52 -0600 (Fri, 02 Nov 2018) | 35 lines
>
> [WebAssembly] Fix bugs in rethrow depth counting and InstPrinter
>
> Summary:
> EH stack depth is incremented at `try` and decremented at `catch`. When
> there are more than two catch instructions for a try instruction, we
>
>
> running make in llvm/build
>
> [ 88%] Building CXX object tools/clang/lib/Tooling/Refactoring/CMakeFiles/clangToolingRefactor.dir/Rename/SymbolOccurrences.cpp.o
> [ 88%] Building CXX object tools/clang/lib/Tooling/Refactoring/CMakeFiles/clangToolingRefactor.dir/Rename/USRFinder.cpp.o
> [ 88%] Building CXX object tools/clang/lib/Tooling/Refactoring/CMakeFiles/clangToolingRefactor.dir/Rename/USRFindingAction.cpp.o
> [ 88%] Building CXX object tools/clang/lib/Tooling/Refactoring/CMakeFiles/clangToolingRefactor.dir/Rename/USRLocFinder.cpp.o
> [ 88%] Linking CXX static library ../../../../../lib/libclangToolingRefactor.a
> [ 88%] Built target clangToolingRefactor
> Scanning dependencies of target clangToolingASTDiff
> [ 88%] Building CXX object tools/clang/lib/Tooling/ASTDiff/CMakeFiles/clangToolingASTDiff.dir/ASTDiff.cpp.o
> [ 88%] Linking CXX static library ../../../../../lib/libclangToolingASTDiff.a
> [ 88%] Built target clangToolingASTDiff
> [ 88%] Built target clangIndex
> [ 88%] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/clangStaticAnalyzerCore.dir/SarifDiagnostics.cpp.o
> /usr/local/src/llvm/tools/clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:86:17: error: no matching function for call to 'next'
>   std::for_each(std::next(sys::path::begin(Filename)), sys::path::end(Filename),
>                 ^~~~~~~~~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:521:25: note: candidate template ignored:
>       disabled by 'enable_if' [with _ForwardIter = llvm::sys::path::const_iterator]
>      typename enable_if<__is_forward_iterator<_ForwardIter>::value>::type* = 0)
>                         ^
> 1 error generated.
> make[2]: *** [tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/clangStaticAnalyzerCore.dir/SarifDiagnostics.cpp.o] Error 1
> make[1]: *** [tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/clangStaticAnalyzerCore.dir/all] Error 2
> make: *** [all] Error 2
>
>
>
> running on Mac OS 10.12.6
>
>  cc --version
> Apple LLVM version 8.1.0 (clang-802.0.42)
> Target: x86_64-apple-darwin16.7.0
> Thread model: posix
> InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
>
> c++ --version
> Apple LLVM version 8.1.0 (clang-802.0.42)
> Target: x86_64-apple-darwin16.7.0
> Thread model: posix
> InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
>
> grady
>
>
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
>