[cfe-dev] [llvm-dev] [Release-testers] [6.0.0 Release] Release Candidate 1 tagged

[Dimitry Andric via cfe-dev]

On 19 Jan 2018, at 17:11, Hans Wennborg <hans at chromium.org> wrote:
> 
> On Thu, Jan 18, 2018 at 7:27 PM, Dimitry Andric <dimitry at andric.com> wrote:
>> On 18 Jan 2018, at 15:03, Jonas Hahnfeld <hahnjo at hahnjo.de> wrote:
>>> 
>>> Am 2018-01-18 14:55, schrieb Dimitry Andric via llvm-dev:
>>>> On 17 Jan 2018, at 18:53, Hans Wennborg via Release-testers
>>>> <release-testers at lists.llvm.org> wrote:
>>>>> Start your engines; 6.0.0-rc1 was just tagged.
>>>>> I know there are still open blockers and it's early in the process in
>>>>> a way, but I'd like to find out where we are. Please run the test
>>>>> script, let me know the results, and upload binaries.
>>>> At the moment I can't compile openmp, since it errors out on libomptarget:
>>>> /home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:50:10:
>>>> error: use of undeclared identifier 'malloc'
>>>>   rc = malloc(size);
>>>>        ^
>>>> /home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:76:5:
>>>> error: use of undeclared identifier 'free'
>>>>   free(device_ptr);
>>>>   ^
>>>> /home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:163:20:
>>>> error: use of undeclared identifier 'malloc'
>>>>   void *buffer = malloc(length);
>>>>                  ^
>>>> I'm trying a local fix here, namely including <cstdlib> at the top of the file.
>>> 
>>> Argh, I have missed that header. Adding <cstdlib> sounds like the right solution, can you submit a patch or directly commit to SVN if it works for you?
>> 
>> I added <cstdlib> to api.cpp, interface.cpp and rtl.cpp, in r322869.  Hans, could you please merge it to release_60, or shall I do it?
> 
> Go ahead if you're set up, otherwise let me know and I'll do it.

Done in r323037.  I have also taken the liberty of merging r322875 and r322879, in which I added a '-no-libcxxabi' option to the test-release.sh script.

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 223 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20180120/a9a5b8ab/attachment.sig>