[cfe-dev] -Wtautological-constant-compare issues

[Roman Lebedev via cfe-dev]

On Tue, Jan 16, 2018 at 8:35 PM, Nico Weber <thakis at chromium.org> wrote:
> Wait, wasn't the consensus here to leave the warning out of -Wextra too?
> Looks like r321691 got that wrong?
Hm, consensus? Since it was pretty quite clear (?) from the diff and commit
message that it was only moved to -Wextra, i guess this was somehow
missed by me and all the reviewers...

On Tue, Jan 16, 2018 at 8:38 PM, Richard Smith via cfe-dev
<cfe-dev at lists.llvm.org> wrote:
> Yes, I'd prefer to take this warning out of -Wextra at least for Clang 6.
What exactly do you have in mind?
Only from release_60 branch, or from trunk+release_60?

> Hopefully we can find good heuristics to suppress the false positives for
> Clang 7 and then re-enable it.
John McCall did post a short summary of what *seemingly* needs to be
done in https://reviews.llvm.org/D39462#917421
To be honest i'm not quite sure where to start on that.

Roman.

> On Tue, Jan 16, 2018 at 12:04 PM, via cfe-dev <cfe-dev at lists.llvm.org>
> wrote:
>>
>> > -----Original Message-----
>> > From: cfe-dev [mailto:cfe-dev-bounces at lists.llvm.org] On Behalf Of Hans
>> > Wennborg via cfe-dev
>> > Sent: Tuesday, January 16, 2018 8:01 AM
>> > To: Roman Lebedev <lebedev.ri at gmail.com>
>> > Cc: Marshall Clow <mclow.lists at gmail.com>; Richard Smith <richard-
>> > llvm at metafoo.co.uk>; cfe-dev at lists.llvm.org; John McCall
>> > <rjmccall at gmail.com>
>> > Subject: Re: [cfe-dev] -Wtautological-constant-compare issues
>> >
>> ...
>> > >>
>> > >> Apologies for coming late to the thread.
>> > > No problem.
>> > >
>> > >> What's the status here? Did everything land, and should we merge
>> > r321691 to 6.0?
>> > > It landed before branching. I see r321691 in release_60 branch.
>> > > So nothing do be done here.
>> >
>> > Ah, right. Thanks for checking! Sorry for the noise.
>> >
>>
>> Can we consider https://reviews.llvm.org/D41727 for inclusion in master
>> and possibly release_60?
>>
>> -Brian
>>
>> _______________________________________________
>> cfe-dev mailing list
>> cfe-dev at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
>