[cfe-dev] Stuck clang-tidy check review, legal issues?

Roman Lebedev via cfe-dev cfe-dev at lists.llvm.org
Thu Oct 5 07:08:23 PDT 2017


I have the following Differential

> ...
> This check checks function Cognitive Complexity metric, and flags
> the functions with Cognitive Complexity exceeding the configured limit.
> The default limit is `25`, same as in 'upstream'.
> The metric is implemented as per [[ https://www.sonarsource.com/docs/
CognitiveComplexity.pdf | COGNITIVE COMPLEXITY by SonarSource ]] specification 
version 1.2 (19 April 2017), with two notable exceptions:
> * `preprocessor conditionals` (`#ifdef`, `#if`, `#elif`, `#else`, `#endif`) 
>    are not accounted for.
>    Could be done. Currently, upstream does not account for them either.
> * `each method in a recursion cycle` is not accounted for.
>    It can't be fully implemented, because cross-translational-unit analysis 
>    would be needed, which is not possible in clang-tidy.
>    Thus, at least right now, i completely avoided implementing it.

As you can see, the implementation is based on a specification.

That Differential was created on 17 Aug, so ~50 days ago. In all this time, 
there has been basically no feedback. Mid-September, thanks to Aaron Ballman,
the first review was done by Jonas Toth. Thanks to both of them!

After that, the code owner, Alexander Kornienko, has left a short message 
questioning the legal status of that code

In my reply https://reviews.llvm.org/D36836#877642 i have shared the email 
exchange which i believe supports my view that it is okay to have this in 
LLVM. Since then, there has been no feedback.

Questions that i'd love to get addressed by this mail
* Am i doing something wrong?
* Am i, as not a lawyer, wrong in my view about the code status?
* Can somebody please review that code? :)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20171005/22809e53/attachment.sig>

More information about the cfe-dev mailing list