[cfe-dev] [clang-format] Spacing in C-like casts

[Richard Smith via cfe-dev]

On 16 May 2017 at 09:15, Oleksii Vilchanskyi via cfe-dev <
cfe-dev at lists.llvm.org> wrote:

> Hi everybody,
>
> Here is a code sample:
>
>
> It was formatted with SpaceAfterCStyleCast: true option. However, while
> bool was formatted, uint8_t wasn't. Looks like a bug to me. Or is it a
> feature? Full config is in the attachment.
>

This is one of the cases for which the C and C++ grammars require
contextual information to parse, which is where clang-format is most likely
to make mistakes. Consider:

  int uint8_t(int); // a function, not a type
  x = (uint8_t)(123); // not a cast

However, given the relative frequency of that case and of C-style casts,
clang-format should probably be assuming that this syntax is a cast. (It's
not completely clear, though; parenthesizing the function name is an idiom
for turning off ADL, and it's possible that there are codebases that make
heavy use of that idiom.)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20170516/2e4e451b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot_20170516_180750.png
Type: image/png
Size: 79485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20170516/2e4e451b/attachment.png>