[cfe-dev] clang-format plugin support for Visual Studio 15.0

[Hans Wennborg via cfe-dev]

Thanks for doing this!

As Paul said in his reply, either just sending the patch to
cfe-commits, or uploading it to reviews.llvm.org works. In any case,
please make sure I'm cc'd.

If upgrading to the new manifest version turns out to be a lot of
work, maybe we should commit your first patch in the meantime so the
plugin can be used even if it displays a warning. Let me know how
things develop.

Cheers,
Hans

On Tue, Mar 28, 2017 at 5:55 AM, Hugo Puhlmann <hugopuhlmann at gmail.com> wrote:
> Hi,
>
> Visual Studio 2017 introduced a new version for its extension manifest, so
> further work will be necessary for a "correct" migration. Right now the
> extension works, but it triggers a warning message saying the extension is
> not fully compatible with VS15.
>
> I'll make the necessary changes and send an updated patch, so you can
> disregard the first one.
>
> In case anyone is curious, this post details the changes in the extension
> SDK
> http://www.visualstudioextensibility.com/2016/11/16/visual-studio-2017-rc-announced-extensions-need-some-changes/
>
> On Mon, Mar 27, 2017 at 10:57 PM, Hugo Puhlmann <hugopuhlmann at gmail.com>
> wrote:
>>
>> Hi,
>>
>> Since there seems to be interest in VS15 support I'm submiting the patch I
>> mentioned back in January.
>>
>> I'm not sure if I can just submit it here, or if I should start another
>> email thread for the patch itself, so apologies if it shouldn't have been
>> here.
>>
>> On Thu, Jan 26, 2017 at 8:39 PM, Hans Wennborg <hans at chromium.org> wrote:
>>>
>>> On Sun, Jan 15, 2017 at 4:26 PM, Hugo Puhlmann via cfe-dev
>>> <cfe-dev at lists.llvm.org> wrote:
>>> > Hi Piortr,
>>> >
>>> > I believe the one you linked is only supported by VS Code, not Visual
>>> > Studio
>>> > Community and similar.
>>> >
>>> > There's already a version for Visual Studio 2015 on
>>> > http://llvm.org/builds,
>>> > but hat to build it myself for 2017RC.
>>>
>>> That one is also available here:
>>>
>>> https://marketplace.visualstudio.com/items?itemName=HansWennborg.ClangFormat
>>>
>>> If you have a patch for the manifest that makes the plugin work in
>>> 2017RC, feel free to send it to the list. I don't think we'll want to
>>> migrate the csproject yet though, as it needs to keep building with
>>> 2015.
>>>
>>> Cheers,
>>> Hans
>>>
>>> >
>>> > On Sun, Jan 15, 2017 at 5:51 PM, Piotr Padlewski
>>> > <piotr.padlewski at gmail.com>
>>> > wrote:
>>> >>
>>> >> Hi,
>>> >> I thought that there is already clang-format plugin
>>> >> https://marketplace.visualstudio.com/items?itemName=xaver.clang-format
>>> >>
>>> >> Have you built your own plugin, or updated this one to make it work
>>> >> with
>>> >> new Visual?
>>> >>
>>> >> Piotr
>>> >>
>>> >> 2017-01-14 15:37 GMT+01:00 Hugo Puhlmann via cfe-dev
>>> >> <cfe-dev at lists.llvm.org>:
>>> >>>
>>> >>> Hi,
>>> >>>
>>> >>> I've recently managed to build and use a version of the clang-format
>>> >>> plugin for VS 15.0, so I was wondering anyone would be interested in
>>> >>> making
>>> >>> the vsix package available somewhere public, like
>>> >>> http://llvm.org/builds or
>>> >>> similar.
>>> >>>
>>> >>> I could also submit a patch with the changes I've made, but since VS
>>> >>> 15.0
>>> >>> is still an RC and required me to upgrade the csproj version, it
>>> >>> might be
>>> >>> too early for that. The only change on the plugin itself was adding
>>> >>> VS15 to
>>> >>> the list of supported targets(source.extension.vsixmanifest.in), but
>>> >>> I also
>>> >>> needed to make some changes to be able to build the clang-format
>>> >>> tool.
>>> >>>
>>> >>> If anyone is interested, please let me know so I can send the
>>> >>> package.
>>> >>> --
>>> >>> []'s,
>>> >>> Hugo Puhlmann
>>> >>>
>>> >>> _______________________________________________
>>> >>> cfe-dev mailing list
>>> >>> cfe-dev at lists.llvm.org
>>> >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>>> >>>
>>> >>
>>> >
>>> >
>>> >
>>> > --
>>> > []'s,
>>> > Hugo Puhlmann
>>> >
>>> > _______________________________________________
>>> > cfe-dev mailing list
>>> > cfe-dev at lists.llvm.org
>>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>>> >
>>
>>
>>
>>
>> --
>> []'s,
>> Hugo Puhlmann
>
>
>
>
> --
> []'s,
> Hugo Puhlmann