[cfe-dev] misprint in clang::ASTContext::getSubstTemplateTypeParmPackType

[George Burgess IV via cfe-dev]

Thanks for bringing this up!

Definitely looks like a typo. Fixed in r305207. :)

George

On Fri, Jun 9, 2017 at 6:27 AM, Vladimir Voskresensky
<Vladimir.Voskresensky at oracle.com> wrote:
> Ping.
> George, could you have a look at this misprint, please?
>
> Thanks
> Vladimir.
>
>
> On 06/ 6/17 07:48 PM, Vladimir Voskresensky via cfe-dev wrote:
>
> Hello,
>
> Is there a misprint in clang::ASTContext::getSubstTemplateTypeParmPackType
> method?
> The last lines should use collection SubstTemplateTypeParm*PACK*Types, not
> SubstTemplateTypeParmTypes
>
> - SubstTemplateTypeParmTypes.InsertNode(SubstParm, InsertPos);
> return QualType(SubstParm, 0);
> =>
> + SubstTemplateTypeParmPackTypes.InsertNode(SubstParm, InsertPos);
> return QualType(SubstParm, 0);
>
> otherwise not clear how InsertPos calcualted for
> SubstTemplateTypeParmPackTypes can be used in InsertNode for another
> collection
>
> Hope it helps,
> Vladimir.
>
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
>