[cfe-dev] Using Clang 5.0.0 RC2 with MSVC dev builds

[don hinton via cfe-dev]

I wouldn't use my initial attempt.  Instead of trying to cache linkPath
directly, one should override getDefaultLinker() and add the bin path to
FilePaths.

Then you could simplify setting linkPath, but doesn't solve all the
problems.

The only other thing I'd suggest would be to remove the check for VC.

On Thu, Aug 17, 2017 at 7:12 PM, Stephan T. Lavavej <
stl at exchange.microsoft.com> wrote:

> [Zachary Turner]
> > Double checked the code.  We use the lib path in case the user doesn't
> specify -libpath.  But, looks like we already have an option for that,
> -libpath.
> > We need the bin path to find cl.exe (for fallback) and link.exe.
> > We also use the deduced include path when trying to find universal CRT,
> and I'm not sure if that's covered by -imsvc.
>
> Don sent me https://reviews.llvm.org/D36842 which I built and hacked
> until I came up with https://reviews.llvm.org/D36857 . This works for my
> x86 dev build (haven't tried x64 yet). I don't know if it's the "right"
> solution, but hopefully it will be of use.
>
> Since it caches the link.exe path, but doesn't really attempt to fix the
> underlying issue of path reconstruction, I don't think things like the
> "fall back to cl.exe" feature would work - but fortunately I never want
> cl.exe fallback with internal dev builds.
>
> STL
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20170817/08a74b78/attachment.html>