[cfe-dev] Clang and multilib search paths

Lei Zhang via cfe-dev cfe-dev at lists.llvm.org
Thu Jul 21 20:05:29 PDT 2016


2016-07-22 1:32 GMT+08:00 Vedant Kumar <vsk at apple.com>:
>
>> On Jul 20, 2016, at 6:03 PM, Lei Zhang <zhanglei.april at gmail.com> wrote:
>>
>> 2016-07-21 7:26 GMT+08:00 Armin K. via cfe-dev <cfe-dev at lists.llvm.org>:
>>> On 21.07.2016 01:24, Vedant Kumar wrote:
>>>> Hi Armin,
>>>>
>>>> Please upload your patch to reviews.llvm.org [1]. Be sure to add a reviewer
>>>> (perhaps Sylvestre Ledru) and subscribe cfe-commits to the review.
>>>>
>>>> best
>>>> vedant
>>>>
>>>> [1] http://llvm.org/docs/Phabricator.html
>>>>
>>>
>>> Hi, I don't think patch is upstreamable, as it changes default runtime
>>> to compiler-rt for all of linux. This was just an FYI. Also, I can't
>>> submit it with current distro detection, as all Linux From Scratch users
>>> would be affected, and I can't allow that.
>>
>> Hi Armin,
>>
>> I just sent a patch for clang a few days ago, which allows the default
>> runtime lib to be set at build time (either libgcc or compiler-rt). It
>> might be helpful to you.
>>
>> http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160711/164903.html
>>
>> BTW, I haven't got any response after sending that patch. Could
>> someone help reviewing it?
>
> The patch looks fine to me, but I don't think I can lgtm it.
>
> I suggest uploading the patch to Phab and adding one or two suitable reviewers.
> E.g in this case, looking through the git history, Mike Spertus and/or Chris
> Bieneman could be good reviewers.

Thanks for your advice :)

Now submitted: https://reviews.llvm.org/D22663


Lei



More information about the cfe-dev mailing list