[cfe-dev] [libcxx][filesystem] Test for last_write_time

[Eric Fiselier via cfe-dev]

@Jonas Could you please confirm this patch works?

https://reviews.llvm.org/D22452

/Eric

On Fri, Jul 15, 2016 at 10:26 AM, David Majnemer <david.majnemer at gmail.com>
wrote:

> Please send patches to cfe-commits.
>
> On Thu, Jul 14, 2016 at 10:59 PM, Hahnfeld, Jonas via cfe-dev <
> cfe-dev at lists.llvm.org> wrote:
>
>> Great. Could you possibly also have a look at this patch, that fixes a
>> problem with setgid? https://reviews.llvm.org/D22265
>>
>>
>>
>> Thanks,
>>
>> Jonas
>>
>>
>>
>> *From:* Eric Fiselier [mailto:eric at efcs.ca]
>> *Sent:* Thursday, July 14, 2016 10:30 PM
>> *To:* Hahnfeld, Jonas
>> *Cc:* cfe-dev at lists.llvm.org
>> *Subject:* Re: [libcxx][filesystem] Test for last_write_time
>>
>>
>>
>> Thanks for the info Jonas, I'll clean up those tests.
>>
>>
>>
>> /Eric
>>
>>
>>
>> On Wed, Jul 13, 2016 at 1:23 AM, Hahnfeld, Jonas <
>> Hahnfeld at itc.rwth-aachen.de> wrote:
>>
>> Dear all,
>>
>> I'm currently experiencing some issues with
>>
>> test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_writ
>> e_time.pass.cpp, with the test cases set_last_write_time_dynamic_env_test,
>> test_write_min_time and test_write_min_max_time to be more specific.
>> They try to set negative timestamps (before 1970), file_time_type::min()
>> and
>> file_time_type::max(). My NFS setup doesn't like that and therefore fails
>> these tests. XFS works but I think ext4 also has limitations on its
>> timestamps. I wonder if it's a good idea to have tests that rely on
>> filesystem behavior that is not guaranteed...
>>
>> Regards,
>> Jonas
>>
>>
>> --
>> Jonas Hahnfeld, MATSE-Auszubildender
>>
>> IT Center
>> Group: High Performance Computing
>> Division: Computational Science and Engineering
>> RWTH Aachen University
>> Seffenter Weg 23
>> D 52074  Aachen (Germany)
>> Hahnfeld at itc.rwth-aachen.de
>> www.itc.rwth-aachen.de
>>
>>
>>
>> _______________________________________________
>> cfe-dev mailing list
>> cfe-dev at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20160717/e2791f5f/attachment.html>