[cfe-dev] [llvm-dev] [lldb-dev] Sequential ID Git hook

Jared Grubb via cfe-dev cfe-dev at lists.llvm.org
Mon Jul 4 12:21:30 PDT 2016


> El jul. 4, 2016, a las 11:15, Renato Golin <renato.golin at linaro.org> escribió:
> 
> On 4 July 2016 at 15:21, Bruce Hoult <bruce at hoult.org> wrote:
>> What doesn't scale about tagging every commit?
> 
> Both Jim and Takumi have reported problems with thousands of tags.
> Even though neither of them responded to your enquiries for additional
> data, we can't assume there isn't any.

Agreed. Adding a tag to every commit (especially in something with as many commits as LLVM/clang) would be a nightmare for anyone that the pretty forms of git-log (eg, "git log --graph --abbrev-commit --pretty=oneline --decorate --color") or GUI-based programs for Git. I imagine the dropdown menus on Github wouldn't be fun to use either.

> Furthermore, "git describe" seems to be the "mixed mode" I asked
> about, and it's already in git since an old version, so I'm not sure
> why we'd even need to create one tag per commit anyway.
> 
> People should be using Git for bisects, in which case it works out of
> the box. The incremental version was mostly to tag the build with
> something meaningful, which "git describe" is.
> 
> Even if you want to use the result of describe to bisect like SVN, it
> works because our history is linear (and you can count the number of
> commits between A and B, and even store a local list of the hashes in
> between.
> 
> I really can't see why would we need to tag every commit.
> 
> cheers,
> --renato




More information about the cfe-dev mailing list