[cfe-dev] [3.8 Release] We have branched

[Daniel Sanders via cfe-dev]

Hi Hans,

I tried the release branch last night and I'm having problems building it. The problem is that test-suite is now building as part of the Phase[123] builds (because this project contains CMakeLists.txt's now) but cmake 3.0.2 (from Debian Jessie) generates an invalid Makefile.
The error is:
	CMakeFiles/test-suite.dir/build.make:112: *** target pattern contains no '%'.  Stop.
	CMakeFiles/Makefile2:199: recipe for target 'CMakeFiles/test-suite.dir/all' failed
And the referenced line of the generated makefile is:
	test-suite-stamps/test-suite-force-rebuild: /home/das-local/llvm-release-3.8/release/branches_release_38/llvm.src/$<TARGET_FILE:clang>
it looks like cmake isn't fully expanding its generator expressions.

Looking at my logs, it looks like the test-suite used to configure in 3.6.2 but didn't build as part of test-release.sh and then 3.7.0 stopped since we had switched to cmake and there was no CMakeLists.txt.
I've always run the test-suite as a separate step as described in http://llvm.org/docs/ReleaseProcess.html. Should we stop creating the projects/test-suite symlink to get back to the behaviour from 3.7.0 or should we do something else?

> -----Original Message-----
> From: cfe-dev [mailto:cfe-dev-bounces at lists.llvm.org] On Behalf Of Hans
> Wennborg via cfe-dev
> Sent: 13 January 2016 18:21
> To: llvm-dev; cfe-dev; lldb-dev at lists.llvm.org; openmp-dev at lists.llvm.org
> Subject: [cfe-dev] [3.8 Release] We have branched
> 
> And so the release process begins.
> 
> The 3.8 branch was created today from trunk at r257626, and the trunk
> version was then bumped to 3.9.
> 
> Release blockers are tracked by http://llvm.org/PR26059. If you find
> any bugs (either new or already in the tracker) that you think need to
> be fixed before the release, please mark them as blocking this bug.
> 
> To get a change committed on the branch, first commit it to trunk as
> usual, then reply to the commit message on the mailing list with
> myself and the appropriate code owner CC'd, asking for the change to
> be merged to the branch.
> 
> Release notes for 3.8 should be committed directly to the branch, or
> sent to me in an email and I'll do it for you. If you made any
> non-trivial changes in the last six months (or know someone else who
> did), please make sure they get mentioned in the notes.
> 
> Next up on the schedule is preparing the first release candidate
> (RC1). This will happen in a few days, once the branch is known to be
> in good shape.
> 
> The hardest part of releasing is staying on top of everything. Please
> help me out by CC'ing me on any bugs, commits, or other issues that
> are relevant for the release. If I'm not CC'd, there's a large chance
> I will miss it.
> 
> Cheers,
> Hans
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev