[cfe-dev] clang-rename performance oddness

[Miklos Vajna via cfe-dev]

Hi Ben,

On Wed, Aug 17, 2016 at 11:22:50AM -0500, "Craig, Ben via cfe-dev" <cfe-dev at lists.llvm.org> wrote:
> In looking at the top level code, I do see one thing that I don't
> particularly care for...
> 
> Each symbol to be renamed causes a new frontend action to be taken.  That
> eventually means a full re-parsing of the AST.  I would hope / expect that I
> could gain significant performance by passing multiple renamings in one
> clang-rename invocation, but that doesn't look to be the case.
> 
> So the problem isn't that ParseAST() is slow, it's that it's being called
> too many times.

Yes, thanks, it'll be probably
tools/clang/tools/extra/clang-rename/tool/ClangRename.cpp:219 that is
called in a loop. Kirill or me will have a look.

Regards,

Miklos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20160818/070c5a81/attachment.sig>