[cfe-dev] Regression with commit 264241

[Neil Henning via cfe-dev]

Hey Eric!

I thought as much, I'll do a simple patch to remove the assert.

Cheers,
-Neil.

On 22/04/16 18:15, Eric Christopher wrote:
> As you are one of the spir v authors I feel you can make this call. :) 
> I doubt it'll run into anything Anastasia is doing either as she's 
> focused on opencl.
>
> On Fri, Apr 22, 2016, 2:54 AM Neil Henning via cfe-dev 
> <cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>> wrote:
>
>     Hey all,
>
>     We've just bumped our clang revision internally and found the
>     following
>     regression with SVN 264241 (differential
>     http://reviews.llvm.org/D17596).
>
>     The line that is causing us umbrage is in
>     clang/lib/CodeGen/TargetInfo.cpp:7393:
>
>     assert(CGM.getLangOpts().OpenCL && "SPIR is only for OpenCL");
>
>     We compile from non-OpenCL sources targeting SPIR/SPIR64, and then
>     link
>     these with OpenCL kernels. Because of the assert, we can no longer
>     compile the non-OpenCL source files.
>
>     Would anyone greatly miss us removing this assert? Locally everything
>     works as expected when I do this.
>
>     -Neil.
>     _______________________________________________
>     cfe-dev mailing list
>     cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>
>     http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20160423/f1c432a3/attachment.html>