[cfe-dev] How to write tests for ASTImporter?

Serge Pavlov via cfe-dev cfe-dev at lists.llvm.org
Mon Nov 2 06:20:10 PST 2015


Great!

Looking forward your patch set.

Thanks,
--Serge

2015-11-02 19:30 GMT+06:00 Aleksei Sidorin <a.sidorin at samsung.com>:

> Hello Serge,
>
> thank you for your reply.
> I'll definitely take a look at your patch. My patch seems to cover most of
> your work and even more: it seems to be powerful enough for implementation
> of inter-unit analysis for Static Analyzer. If I'll submit a review, could
> I add you as a reviewer? I'll split it into multiple patches since it is
> more than 3k SLoc.
>
>
> 02.11.2015 14:23, Serge Pavlov пишет:
>
> Hi Alexei,
>
> ASTImporter seems to be unfinished yet, it even didn't handled
> StringLiteral. Nevertheless it is a useful tool and if  handling some nodes
> is implemented, it works. I put the implementation of nodes interesting to
> me into review request (http://reviews.llvm.org/D14224). Probably we
> intersect in simple nodes but there are many nodes unimplemented yet.
>
> If you are going to develop ASTImporter, it is great, as import facility
> is a powerful technique for syntax tools.
>
> Existing test do not test import facility thoroughly. Some test may use
> static_assert, it is convenient for compile only tests. If the imported
> handled all nodes, it could be tested by compiling a source file into ast
>  and then compiling an empty file with merging the compiled ast file. Now
> this way to test is not available though.
>
>
> Thanks,
> --Serge
>
> 2015-10-30 15:58 GMT+06:00 Aleksei Sidorin via cfe-dev <
> <cfe-dev at lists.llvm.org>cfe-dev at lists.llvm.org>:
>
>> Hello,
>>
>> I have some patches for ASTImporter I wish to contribute. However, I
>> didn't find much tests for it in clang test suite and I wonder if there is
>> a way to write tests for ASTImporter? The only tests I found were dedicated
>> to conflicting declarations.
>>
>> --
>> Best regards,
>> Aleksei Sidorin
>> Software Engineer,
>> IMSWL-IMCG, SRR, Samsung Electronics
>>
>> _______________________________________________
>> cfe-dev mailing list
>> cfe-dev at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>>
>
>
>
> --
> Best regards,
> Aleksei Sidorin
> Software Engineer,
> IMSWL-IMCG, SRR, Samsung Electronics
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20151102/2eb8662c/attachment.html>


More information about the cfe-dev mailing list