[cfe-dev] tgmath.h

[Sean Silva]

On Tue, Jun 9, 2015 at 3:32 AM, Daniel Sanders <Daniel.Sanders at imgtec.com>
wrote:

> Hi,
>
> I'm not suitable to review the change but there's a couple things I can
> comment on to help you get your change reviewed.
>
> > That way tgmath can be used with, say, VS 2010, which is the one I am
> using,
> > so far without any problem.
>
> I believe there was a policy decision to support only the last two major
> releases of GCC, Clang, and Visual Studio and our getting started page (
> http://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library)
> lists Visual Studio 2013 as being the minimum supported version. At the
> time the decision was made, this was necessary to be able to migrate to
> C++11.
>

The tgmath.h in clang/lib/Headers/tgmath.h is one of clang's builtin
headers. They are used while compiling users' code, not while compiling
clang itself. Clang is the only compiler that is ever intended to see these
headers.

-- Sean Silva


>
> > If nobody spots a bug in the following days I may upload the file, is it
> right?
>
> Generally speaking, you'll need to wait for someone to review your patch
> and approve it. You'll need to send a patch to cfe-commits rather than
> attach your modified file though. At the moment, it's difficult to tell
> what changes you made.
>
> Please see
> http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch
> and http://llvm.org/docs/DeveloperPolicy.html#code-reviews for more
> information.
>
> Hope that helps
>
> > -----Original Message-----
> > From: cfe-dev-bounces at cs.uiuc.edu [mailto:cfe-dev-bounces at cs.uiuc.edu]
> > On Behalf Of Javier Múgica
> > Sent: 09 June 2015 09:14
> > To: Clang development community
> > Subject: [cfe-dev] tgmath.h
> >
> > Hello:
> >
> > I have made some changes to tgmath.h. There could be seen repetitive
> > definitions, so I defined some macros in order to add some structure
> there
> > and make the file smaller and, in my opinion, more readable. I also
> added a
> > test to see if the implementatinos suports complex numbers and surrounded
> > the code that uses those types under the corresponding #ifdef #endif.
> >
> > That way tgmath can be used with, say, VS 2010, which is the one I am
> using,
> > so far without any problem.
> >
> > If nobody spots a bug in the following days I may upload the file, is it
> right?
> >
> > Regards,
> >
> > Javier A. Múgica
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20150609/b677e6fb/attachment.html>