[cfe-dev] tgmath.h

[Daniel Sanders]

Hi,

I'm not suitable to review the change but there's a couple things I can comment on to help you get your change reviewed.

> That way tgmath can be used with, say, VS 2010, which is the one I am using,
> so far without any problem.

I believe there was a policy decision to support only the last two major releases of GCC, Clang, and Visual Studio and our getting started page (http://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library) lists Visual Studio 2013 as being the minimum supported version. At the time the decision was made, this was necessary to be able to migrate to C++11.

> If nobody spots a bug in the following days I may upload the file, is it right?

Generally speaking, you'll need to wait for someone to review your patch and approve it. You'll need to send a patch to cfe-commits rather than attach your modified file though. At the moment, it's difficult to tell what changes you made.

Please see http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch and http://llvm.org/docs/DeveloperPolicy.html#code-reviews for more information.

Hope that helps

> -----Original Message-----
> From: cfe-dev-bounces at cs.uiuc.edu [mailto:cfe-dev-bounces at cs.uiuc.edu]
> On Behalf Of Javier Múgica
> Sent: 09 June 2015 09:14
> To: Clang development community
> Subject: [cfe-dev] tgmath.h
> 
> Hello:
> 
> I have made some changes to tgmath.h. There could be seen repetitive
> definitions, so I defined some macros in order to add some structure there
> and make the file smaller and, in my opinion, more readable. I also added a
> test to see if the implementatinos suports complex numbers and surrounded
> the code that uses those types under the corresponding #ifdef #endif.
> 
> That way tgmath can be used with, say, VS 2010, which is the one I am using,
> so far without any problem.
> 
> If nobody spots a bug in the following days I may upload the file, is it right?
> 
> Regards,
> 
> Javier A. Múgica