[cfe-dev] clang-format: Multiple statements in line

[Maurizio Vitale via cfe-dev]

I cannot speak for the developers, but adding a features -- even when it is
not default -- has a cost in that you now have to make sure that it keeps
working properly in face of future developement. And once you start
allowing this you end up having a multitude of settings all not enabled by
default that needs to be crosschecked.
Furthermore, people who contribute their own feature tend to disappear and
not maintain it against new features. So we end up having either to ask the
implementer of the new features to maintain this odd feature that has been
orphaned or somebody else has to adopt it.

So in short, I think only features that are widely useful should get in
(default or not) and I agree on the bar: if it is something that a widely
distributed and used style guide recommends, it should be considered. In
this particular case, my take is that multiple statements on the same line
is something most style guides would discourage (or at most be silent
about). Except in the special case of a for loop, clearly.

On Wed, Aug 26, 2015 at 10:03 AM, Florian Lindner via cfe-dev <
cfe-dev at lists.llvm.org> wrote:

>
> Am Mittwoch, 26. August 2015, 18:40:43 schrieb Daniel Jasper:
> > Sure, there is bugs.llvm.org with a dedicated "Formatter" component.
> >
> > However, the bar for adding such features is:
> > - Large project with open style guide recommending it.
>
> Why that? Of course, I'm not suggesting to change the default setting, but
> I fail to understand how adding such a feature hurts if it doesn't change
> the default.
>
> > - Person willing to contribute an maintain a patch.
>
> Sure.
>
> Best Regards,
> Florian
>
> >
> >
> > On Wed, Aug 26, 2015 at 5:40 PM, Florian Lindner <mailinglists at xgm.de>
> > wrote:
> >
> > > Am Mittwoch, 26. August 2015, 13:11:32 schrieb Daniel Jasper:
> > > > No, there isn't.
> > >
> > > Ok, thanks for that statement. Is this functionality planned somehow?
> Is
> > > there a bug tracker where I can file this as a wishlist item?
> > >
> > > Best Regards,
> > > Florian
> > >
> > > >
> > > > On Wed, Aug 26, 2015 at 11:23 AM, Florian Lindner via cfe-dev <
> > > > cfe-dev at lists.llvm.org> wrote:
> > > >
> > > > > Hello,
> > > > >
> > > > > I have code like that:
> > > > >
> > > > > ierr = KSPDestroy(&ksp);CHKERRQ(ierr);
> > > > >
> > > > > clang-format introduces a linebreak between the two statements. Is
> > > there a
> > > > > possiblity to omit that?
> > > > >
> > > > > My configuration, based on style LLVM:
> > > > >
> > > > > AllowAllParametersOfDeclarationOnNextLine: true
> > > > > AllowShortBlocksOnASingleLine: true
> > > > > AllowShortCaseLabelsOnASingleLine: true
> > > > > AllowShortIfStatementsOnASingleLine: true
> > > > > AllowShortLoopsOnASingleLine: true
> > > > > AllowShortFunctionsOnASingleLine: All
> > > > > AlwaysBreakAfterDefinitionReturnType: false
> > > > > AlwaysBreakTemplateDeclarations: false
> > > > > AlwaysBreakBeforeMultilineStrings: false
> > > > >
> > > > > (I've just set every remotely related option to don't break)
> > > > >
> > > > > Thanks,
> > > > > Florian
> > > > > _______________________________________________
> > > > > cfe-dev mailing list
> > > > > cfe-dev at lists.llvm.org
> > > > > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
> > > > >
> > >
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20150826/63af3602/attachment.html>