[cfe-dev] misleading documentation for PPCallbacks::FileSkipped

[Nikola Smiljanic]

Looks that way at first glance, feel free to submit a patch as there seem
to be quite a few places that need updating.

On Sat, Apr 4, 2015 at 1:15 AM, Vladimir Voskresensky - Oracle <
vladimir.voskresensky at oracle.com> wrote:

> Hello,
>
> It looks like the name and documentation of the first parameter is
> incorrect
>   virtual void FileSkipped(const FileEntry &ParentFile,
>                            const Token &FilenameTok,
>                            SrcMgr::CharacteristicKind FileType) {
>   }
>
> passed ParentFile is in fact SkippedFile.
>
> The code from Preprocessor::HandleIncludeDirective which calls
> FileSkipped:
>
>   // Ask HeaderInfo if we should enter this #include file. If not,
> #including
>   // this file will have no effect.
>   if (!HeaderInfo.ShouldEnterIncludeFile(File, isImport)) {
>     if (Callbacks)
>       Callbacks->FileSkipped(*File, FilenameTok, FileCharacter);
>     return;
>   }
>
>
> Thanks,
> Vladimir.
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20150414/4d3b4fc1/attachment.html>